-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prettier and improve ESLint #51
Conversation
@Jack-Barry Looks good, but please don't try to remove Babel, since it is much faster than TypeScript compiler and is useful in various scenarios, for example to run |
@larixer Yeah, I figured it was in there for some reason - is it being used by |
@Jack-Barry Mochapack currently requires you to run compilation in production mode prior to using it in 'yarn link'-mode or prior to running integration tests on it. Most projects out there uses this way. But there is a better way, actually have two modes of working with source code:
I really appreciate that you have already make many enhancements to make contributors lives easier. The one I'm talking above is just one of them that is to be done. So don't remove Babel completely please, it will be needed. As for the production build, it is fine to run just |
@larixer Got it 👍🏻 Thanks for the explanation, that's good stuff to know! |
What's the problem this PR addresses?
Recently, we shifted this repo over to TypeScript.
How did you fix it?
posttest
script so that it will be triggered prior to linting when tests are run (just in case someone isn't using auto format on save)Nothing about the library's core functionality changed, but most files were updated by Prettier to do things like remove semi-colons and clean up formatting
Bonus
I'm pretty sure a lot of the Babel stuff can be ripped out now too, just haven't done so yet since I'm not sure which parts are for building vs. test vs. used by the package itself.