Refactor Feature/Module/connector => "Plugin" (Second try) #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Step one of the refactor: renamed the files to preserve history. Note that tests of this commit will fail. * rename src/client/modules=>src/client/plugins * rename src/client/modules/connector.js=>src/client/plugins/plugin.js * rename src/client/modules/connector.web.js=>src/client/plugins/plugin.web.js * rename src/server/modules=>src/server/plugins * rename src/server/modules/connector.js=>src/server/plugins/plugin.js * rename plug folders and files in tools/templates
To improve clarity and distinguish from renaming other connector.js imports to plugin.js
* Renamed Feature class to Plugin * Renamed module[s] variables to plugin[s]
Refactor Feature/Module/connector => Plugin
|
Still some problems here. Will fix and reissue a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #565
Renamed modules folders to plugins
Renamed connector.js to plugin.js
Renamed Feature class to Plugin
Renamed modules variables to plugins
Renamed misc other Module___.___ files to Plugin___.___