Refactor Feature/Module/connector => "Plugin" #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed modules folders to plugins
* Renamed connector.js to plugin.js
* Renamed Feature class to Plugin
* Renamed modules variables to plugins
* Renamed misc other Module___.___ files to Plugin___.___
Refactor from Feature/Module/Connector to Plugin
|
Hold on. Looks like some recent changes conflicted. I'll merge master. |
larixer
reviewed
Dec 23, 2017
| import createResolvers from './resolvers'; | ||
| import Feature from '../connector'; | ||
|
|
||
| export default new Feature({ schema, createResolversFunc: createResolvers }); |
There was a problem hiding this comment.
Looks like Git didn't understand that you have renamed this file, because you have both renamed and changed its contents. In such cases I recommend to rename all files in the first commit and change them in the second commit. Unfortunately I will be unable to merge this PR if it will have places where Git have lost track of some file and diff has all - on all +, because it will be a major headache to merge this change into multiple other open PRs
There was a problem hiding this comment.
I'll retract this PR and try again.
|
@Vlasenko - I'm going to issue a new PR that preserves the history. |
|
Thank you for that @aneilbaboo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #565