Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to docs/FAQ and docs/Configuration #1234

Closed
wants to merge 2 commits into from
Closed

Made changes to docs/FAQ and docs/Configuration #1234

wants to merge 2 commits into from

Conversation

Minus0149
Copy link
Contributor

As shown in issue #1113 "Docs refer to user.js which appears to be in auth.js and has been somewhat restructured" changed the document according to the instructions given as the original was pointing towards wrong file.

AndSviat and others added 2 commits December 12, 2018 11:13
As shown in issue #1113 "Docs refer to user.js which appears to be in auth.js and has been somewhat restructured" changed the document according to the instructions given as the original was pointing towards wrong file.
@larixer
Copy link
Member

larixer commented Dec 14, 2023

Thanks, but why do you add Scala doc in this PR?

@Minus0149
Copy link
Contributor Author

@larixer I did not.
image
as you could see in the image it was added by AndSviat.

@larixer
Copy link
Member

larixer commented Dec 14, 2023

I know, but the question is why it is in your PR?
image

@Minus0149
Copy link
Contributor Author

@larixer I created a pull request for just those 2 files namely faq and configuration. I don't understand how it got included. My deepest apologies for the confusion caused.

@larixer
Copy link
Member

larixer commented Dec 14, 2023

@Minus0149 You have forked from docs branch, that branch was a temporarily and now it is heavily outdated, all the development happens on master, if you want correct docs, please do it by forking master instead and creating PR after that.

@Minus0149
Copy link
Contributor Author

@larixer Done you could check #1235 PR.

@larixer larixer closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants