Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Check GitHub for updates #712

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

EdGeraghty
Copy link
Collaborator

@EdGeraghty EdGeraghty commented Jul 30, 2022

Types

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which improves code quality - QA thoroughly )
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (updates that would not affect or change the code involving the app itself)

Changes

🔮 Features

Opt-in Advanced Setting to poll GitHub for updated releases (closes #711)

🐛 Fixes

🔒 Security

🛠 Performance

📐 Refactoring

Media (if applicable)

QA

  • Signup
  • Login
  • Logout
  • Unencrypted Chat
  • Encrypted Chat
  • Group Chats
  • Profile Changes
  • Theming Changes
  • Force Kill and Restart

Final Checklist

  • All associated issues have been linked to PR
  • All necessary changes made to the documentation
  • Parties interested in these changes have been notified
  • Linter has been run on all code in the PR

@EdGeraghty EdGeraghty added the approved Current description and details of feature have been approved for dev by core team label Jul 30, 2022
@EdGeraghty EdGeraghty self-assigned this Jul 30, 2022
@EdGeraghty

This comment was marked as resolved.

@EdGeraghty EdGeraghty added the help wanted Extra attention is needed label Jul 30, 2022
@EdGeraghty

This comment was marked as resolved.

Committed by accident!
pubspec.lock Outdated Show resolved Hide resolved
@ereio
Copy link
Member

ereio commented Sep 11, 2022

I'll add the dialog here in a bit

Was wondering if we could add another saved state variable to allow for dismissing the dialog without it popping up each time
Ideally we could just save an updateAcknowledgedTimestamp and if that timestamp is greater than the update time, it won't appear

Happy to add that too unless you'd like / want to do the work for that :)

Once both are added, I'll approve! good work! 🚀

@ereio ereio self-requested a review September 11, 2022 19:30
@ereio ereio changed the title [Feature] Check GitHub for updates [feature] Check GitHub for updates Sep 11, 2022
@ereio ereio marked this pull request as ready for review September 11, 2022 21:23
@ereio
Copy link
Member

ereio commented Sep 11, 2022

@EdGeraghty this should work now, if you were testing before would you mind checking this out?

Also what are you thoughts on a redirect vs. downloading the APK directly? I've added a redirect right now and I think that's fine but happy to change it

@EdGeraghty
Copy link
Collaborator Author

If we leave it going to the releases page it'll cover desktop builds too 🎉

@EdGeraghty
Copy link
Collaborator Author

EdGeraghty commented Sep 13, 2022

this should work now, if you were testing before would you mind checking this out?

I'm struggling to make it fire on Windows Desktop, but I don't know if that's a config thing. When I've a little time I'll try an Android build and see what happens there.

@ereio
Copy link
Member

ereio commented Dec 4, 2022

If we're happy without the desktop portion of this working, are we ok to merge this for now? @EdGeraghty

ereio
ereio previously approved these changes Dec 4, 2022
@ereio ereio removed the help wanted Extra attention is needed label Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Current description and details of feature have been approved for dev by core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check GitHub for new releases
2 participants