-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Check GitHub for updates #712
base: dev
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'd rather be safe than sorry!
Just so we don't needlessly fire
This now works cross-platform 🎉
Committed by accident!
I'll add the dialog here in a bit Was wondering if we could add another saved state variable to allow for dismissing the dialog without it popping up each time Happy to add that too unless you'd like / want to do the work for that :) Once both are added, I'll approve! good work! 🚀 |
…-github-for-updates
…ecent checks and dismissed versions, still needs the redirect to github and / or the download itself
@EdGeraghty this should work now, if you were testing before would you mind checking this out? Also what are you thoughts on a redirect vs. downloading the APK directly? I've added a redirect right now and I think that's fine but happy to change it |
If we leave it going to the releases page it'll cover desktop builds too 🎉 |
I'm struggling to make it fire on Windows Desktop, but I don't know if that's a config thing. When I've a little time I'll try an Android build and see what happens there. |
If we're happy without the desktop portion of this working, are we ok to merge this for now? @EdGeraghty |
Types
Changes
🔮 Features
Opt-in Advanced Setting to poll GitHub for updated releases (closes #711)
🐛 Fixes
🔒 Security
🛠 Performance
📐 Refactoring
Media (if applicable)
QA
Final Checklist