feat(components): create the post-breadcrumb-item #3659
Conversation
🦋 Changeset detectedLatest commit: be1ecbd The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -18,24 +18,3 @@ | |||
| font-weight: type.$font-weight-normal; | |||
| white-space: nowrap; | |||
| } | |||
|
|
|||
| .breadcrumb-item { | |||
There was a problem hiding this comment.
Removing these styles is a breaking change. Could you write a changeset to documented this?
| tokens.$default-map: components.$post-breadcrumb; | ||
|
|
||
| :host { | ||
| display: block; |
There was a problem hiding this comment.
| display: block; | |
| display: inline-block; |
| a { | ||
| display: inline-flex; | ||
| align-items: center; | ||
| padding-block: tokens.get('post-breadcrumb', 'padding-block-text'); |
There was a problem hiding this comment.
Can you update the styles to use the tokens function the new way?
| padding-block: tokens.get('post-breadcrumb', 'padding-block-text'); | |
| padding-block: tokens.get('breadcrumb-padding-block-text'); |
| /** | ||
| * The URL to which the breadcrumb item will link. | ||
| */ | ||
| @Prop() readonly url!: string; |
There was a problem hiding this comment.
Are we sure the URL should be mandatory?
|
|
||
| @Watch('url') | ||
| validateUrl() { | ||
| checkEmptyOrUrl(this.url, 'The "url" property is invalid'); |
There was a problem hiding this comment.
If the URL is mandatory:
| checkEmptyOrUrl(this.url, 'The "url" property is invalid'); | |
| checkUrl(this.url, 'The "url" property is invalid'); |
alizedebray
changed the title
|
No description provided.