Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI repair #157

Merged
merged 4 commits into from
Sep 23, 2024
Merged

CI repair #157

merged 4 commits into from
Sep 23, 2024

Conversation

jpgrayson
Copy link
Contributor

N.B. there remains a GitHub deprecation warning related to codecov/codecov-action@v2, which uses an out of date version of node. But to migrate to codecov/codecov-action@v4 requires setting up a codecov token as described here, which requires a repo admin permissions.

The previous certs had expired.

Fixes: swift-server-community#156
Resolves ci-time warnings.
Also use release 5.10 image in matrix.
@adam-fowler
Copy link
Collaborator

I'm wondering if a better solution is to generate new certs in the GitHub action so they never expire for CI.

@adam-fowler
Copy link
Collaborator

Also codecov wasn't even enabled on this repo, when it got moved to swift-server-community. You might as well up the version number on the action and I'll see if I can fix it

This requires a CODECOV_TOKEN secret be configured for the GitHub repo
as described here:

https://docs.codecov.com/docs/adding-the-codecov-token
@jpgrayson
Copy link
Contributor Author

Added the change for codecov. You'll need to define a CODECOV_TOKEN secret as shown here:

https://docs.codecov.com/docs/adding-the-codecov-token

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.12%. Comparing base (e02e237) to head (441baeb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
- Coverage   79.07%   78.12%   -0.96%     
==========================================
  Files          22       22              
  Lines        2518     1979     -539     
==========================================
- Hits         1991     1546     -445     
+ Misses        527      433      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jpgrayson
Copy link
Contributor Author

I'm wondering if a better solution is to generate new certs in the GitHub action so they never expire for CI.

That's an idea. Given the trouble I had with needing to use MacOS' libreSSL versus homebrew's OpenSSL, it might be that the generate-certs.sh script needs some tweaks to be more compatible with the different openssl implementations out there.

@jpgrayson
Copy link
Contributor Author

bump @adam-fowler

I think this PR is ready to go. The updated codecov seems to be working. The CI failure is due to codecov detecting -0.96% less coverage, but the process itself seems to be working.

I was not planning on trying to do the CI-time cert generation in this PR.

@adam-fowler adam-fowler merged commit 9a63aab into swift-server-community:main Sep 23, 2024
10 of 11 checks passed
@adam-fowler
Copy link
Collaborator

Done. Thanks for this @jpgrayson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants