-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove eigen3 #941
Remove eigen3 #941
Conversation
What!!! I have turned off BLASLAPACK, but it seems the CMake is still considering it enabled! |
We definitely want Eigen3 and not BLAS and LAPACK. |
I'm not sure what problem this is trying to solve? |
This one #799 |
I thought that might be it. This is a different problem. The problem is not that Eigen3 is a dependency of DAGMC. The problem is that Eigen3 is included in header files of MOAB and DAGMC that are required by downstream apps, even when it may not be necessary. The solution to this requires a little more careful analysis of each header file that included Eigen3 headers, moving the Eigen3 include to the source file, and seeing whether some forward declarations are necessary where the Eigen3 has been removed from headers. |
Thank you for highlighting the issue with Eigen3 inclusion in header files. |
This PR removes Eigen3 from DAGMC dependency.