Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adversarial_search_fall_2021 #10

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Conversation

theablemo
Copy link

Adversarial search lecture note.

Contributors:

  • Mohammad Abolnejadian
  • MohammadAli Mohammadkhani
  • Matin Daghyani

@@ -0,0 +1,80 @@
{
"cells": [
{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add table of contents!

{
"cells": [
{
"cell_type": "markdown",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to add pictures if possible

"cell_type": "markdown",
"metadata": {},
"source": [
"## Resource Limits\n",
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to make a stronger connection between different parts, for example don't jump into minimax without any preparation, make a strong structure

"One idea might be running the algorithm up to a specified depth instead of the searching the whole tree which(_depth-limited search_).\n",
"\n",
"![hello](1.jpg)"
]
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add conclusion (or summary) and references

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my mistake.

"metadata": {},
"source": [
"### Depth-limited search\n",
"One idea might be running the algorithm up to a specified depth instead of the searching the whole tree which(_depth-limited search_).\n",
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review your english grammar (one example is instead of the searching the whole tree)

Copy link

@sinatav sinatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review

@@ -0,0 +1,80 @@
{
"cells": [
Copy link

@sinatav sinatav Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your file should be .md and not .ipynb

"\n",
"![hello](1.jpg)"
]
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a "other useful links" section can be useful

Copy link

@sinatav sinatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first review v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants