Add arm64 image header bindings #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
reviewed
May 13, 2024
| linux_headers.join("include/asm/image.h"), | ||
| ) | ||
| .expect("Missing headers"); | ||
| } |
There was a problem hiding this comment.
Could you add a comment mentioning that this a hack working around what is believed to be an upstream bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds binding the image header required to boot on arm64/aarch64 systems.
The kernel "make headers_install" does not include the necessary headers when called. I believe this should be reported upstream but in the meantime I had an "hack" which manually copies the necessary headers