Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
defaultProps
has been deprecated on function components in favor of default parameters in React 18.3 (facebook/react#25699). A warning message is logged for every component that usesdefaultProps
which creates a lot of noise and hides other important console messages.We use https://github.com/airbnb/babel-plugin-inline-react-svg/ to transform the SVG files into React components. Historically, the plugin statically assigned default props as
defaultProps
. There's a 4-year-old pull request to add an option to spread props instead (airbnb/babel-plugin-inline-react-svg#86). Unfortunately, it hasn't been merged yet despite repeated prompting.I don't want to fork the library since we have no capacity to maintain it and I still hold out hope that the patch will be eventually merged 🤞
Approach and changes
babel-plugin-inline-react-svg
with the above patch appliedDefinition of done