Fix firehose example #258
Merged
Fix firehose example #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the smart fix! I remember that the root cause was that ATrium requires |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
firehoseexample currently transitively has dependencies on two versions ofcid:v0.10.1andv0.11.1, which have different types forCid.This PR doesn't fix the root issue (haven't had the time to drill down), but adds a newtype + a dependency on the example to convert from the old cid to the new cid.
It's merely a band-aid but I think it's important to keep examples working, as it is a great way of getting started.
Thanks a lot for the library btw :)