:feature: Support fetching multiple layers in a single DB trip #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dealing with maps with many layers there can be many API calls, or, many DB hits depending on how the API is structured. These changes allow for a single DB hit to fetch and concatenate all required layers into a single response.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 156 164 +8
=========================================
+ Hits 156 164 +8
Continue to review full report at Codecov.
|
|
Thank you for suggestion. I'm already thinking about including multiple layer per tile. I suggest to enhance MTVView to use multiple Layer definitions. And cache each layer tile per model last update. Then concatenate each cached tile in response. I think it would be a better way than execute a single database query which can be so large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dealing with maps with many layers there can be many API calls,
or, many DB hits depending on how the API is structured. These changes
allow for a single DB hit to fetch and concatenate all required layers
into a single response.
Please note that this work is currently just a proof-of-concept. I
would want to add tests, documentation, and clean up the code a
bit. I'd like to hear back about whether you think this is valuable or
not before comitting to tidying it up. Cheers!