Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix NEMO Inlet BC #1882

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Fix NEMO Inlet BC #1882

wants to merge 12 commits into from

Conversation

jtneedels
Copy link
Contributor

Proposed Changes

Fix NEMO inlet BC.

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Signed-off-by: jtneedels <[email protected]>
@pr-triage pr-triage bot added the PR: draft label Jan 11, 2023
@jtneedels jtneedels changed the base branch from master to develop January 11, 2023 05:36
@jtneedels
Copy link
Contributor Author

Need to figure out how to adapt for noneq flows. I haven't been able to find a separate description of how to solve for boundary conditions for noneq flows with Riemann invariants.

Common/include/CConfig.hpp Fixed Show fixed Hide fixed
SU2_CFD/src/solvers/CNEMOEulerSolver.cpp Fixed Show fixed Hide fixed
nodes->GetThermalConductivity_ve(iPoint));

/*--- Compute and update residual ---*/
auto residual = visc_numerics->ComputeResidual(config);

Check notice

Code scanning / CodeQL

Declaration hides variable

Variable residual hides another variable of the same name (on [line 2222](1)).
@jtneedels
Copy link
Contributor Author

I've thought about this a bit, and I think the best way forward for this BC is to assume thermal equilibirum in the subsonic flow. In that case the ongoing characteristic for total density can be used to solve for the full thermodynamic state. I think this probably is consistent with use cases such as fuel injection in scramjets, where the injected fluid would be in thermodynamic equilibrium.

@jtneedels
Copy link
Contributor Author

jtneedels commented Jan 23, 2023

@pcarruscag PTAL what would be the best way to handle variable declarations with the switch statement? Either they all need to be pre-declared at the top of the function, or I can declare them inline and restrict the scope, but then the residual computation needs to take place in each case. Which of these ways would be preferred?

@stale
Copy link

stale bot commented May 21, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still a relevant issue please comment on it to restart the discussion. Thank you for your contributions.

@stale stale bot added the stale label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant