Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scriptsBinPath is not a link #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mpr0xy
Copy link

@mpr0xy mpr0xy commented Jan 4, 2023

In some cases, files in the .bin directory are not links, such as in projects generated by rushjs.

In some cases, files in the .bin directory are not links, such as in projects generated by rushjs.
Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpr0xy Could you fix this? 🙏 Thanks!

const scriptsPath = join(resolvedBinPath, '..', '..');
return scriptsPath;
} else if (scriptsBinPathStat.isFile() === true) {
const scriptsPath = join(cwd, '/node_modules/react-scripts');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this might need to be changed to use path.join for cross-platform-compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants