Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and fixes #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Changes and fixes #3

wants to merge 5 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2013

  • Fixed font rendering
  • Updated paths for static files for better compatibility
  • A little bit better error handling for Coinbase api errors
  • More consistent code indentation. There were multiple styles, so I chose the one closest to me. If you don't like it, it should be much easier to update it now, for example to use 4 spaces instead of 2.

@jeffkile
Copy link

Consistant indentation please! My text editor is going nuts!

@ghost
Copy link
Author

ghost commented Sep 25, 2013

Can you show me a screenshot, or tell me which file is it? Maybe I left out something.

@jeffkile
Copy link

I meant on the trunk, It's a change the project really needs.

I tried to clone this pull request to test it out using this command
git clone https://github.com/startup-class/bitstarter-leaderboard.git -b netlovers/develop /bitstarterv2

But I get an error: "Permission denied". I'm a bit new to git and github, do you know what I'm doing wrong? Or can only certain people clone a pull request? Or maybe I should be trying to switch my main checkout over to this branch?

Thanks

@ghost
Copy link
Author

ghost commented Sep 25, 2013

You can try to clone my repo, or fetch the pull requests separately:
https://help.github.com/articles/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant