Memory.

[Alon-Ti]

This change is 

[Alon-Ti]

• Added jmp instructions. #200
• Added addap opcodes. #199
• Memory. #198 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed 8 of 11 files at r1, all commit messages.
Reviewable status: 8 of 11 files reviewed, 7 unresolved discussions (waiting on @Alon-Ti)

---

a discussion (no related file):
Do you merge that to main?

---

runnair/crates/runner/src/memory/relocatable.rs line 1 at r1 (raw file):

use std::collections::HashMap;

Is there a reference to this code so it will be easy to check?

Code quote:

use std::collections::HashMap;

---

runnair/Cargo.toml line 22 at r1 (raw file):

rand = "0.8.5"
serde = "1.0.207"
serde_json = "1.0.1"

Can we take those from the workspace?
I don't want it to have conflicts with Stwo imports as we are going to run this code together.

Code quote:

itertools = "0.12.0"
log = "0.4.21"
num-traits = "0.2.17"
rand = "0.8.5"
serde = "1.0.207"
serde_json = "1.0.1"

---

runnair/crates/runner/src/memory/mod.rs line 16 at r1 (raw file):

#[derive(Debug, Clone, Default)]
pub struct Memory {

Document!

Code quote:

#[derive(Debug, Clone, Default)]
pub struct Memory {

---

runnair/crates/runner/src/memory/mod.rs line 18 at r1 (raw file):

pub struct Memory {
    // TODO(alont) Consdier changing the implementation to segment -> (offset -> value) for memory
    // locality.

Shouldn't we do this TODO now so we won't stuck with this impl?

Code quote:

    // TODO(alont) Consdier changing the implementation to segment -> (offset -> value) for memory
    // locality.

---

runnair/crates/runner/src/memory/mod.rs line 93 at r1 (raw file):

        assert_eq!(memory[M31(1)], QM31::zero().into());
        assert_eq!(memory[M31(1235)], QM31::from(M31(1246)).into());

how did you got this number?

Code quote:

QM31::from(M31(1246)).into()

---

runnair/rust-toolchain.toml line 2 at r1 (raw file):

[toolchain]
channel = "nightly-2024-01-04"

same Q about stwo toolchain

Code quote:

channel = "nightly-2024-01-04"