Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keys ref in starknet_subscribeEvents #243

Merged

Conversation

franciszekjob
Copy link

@franciszekjob franciszekjob commented Nov 8, 2024

This change is Reviewable

@franciszekjob franciszekjob changed the base branch from master to v0.8.0 November 8, 2024 09:24
@ArielElp ArielElp self-requested a review November 11, 2024 06:51
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @franciszekjob)

@amanusk
Copy link
Collaborator

amanusk commented Nov 11, 2024

Can you please rebase this on top of latest v0.8.0, just so CI would pass :)

@ArielElp
Copy link
Collaborator

it's the updated validation script failing actually, no merge conflicts

@franciszekjob
Copy link
Author

franciszekjob commented Nov 11, 2024

@ArielElp @amanusk yup, for some reason the validation fails. However, it's not related with the change, same CI fail happened in other PR from what I see.

@amanusk
Copy link
Collaborator

amanusk commented Nov 12, 2024

This PR: #235
Introduced a fix to the validation script and to the spec.
Since your PR was suggested before this fix was introduced, the CI is running on your codebase, and not the codebase after the merge.
There are no conflicts for merging, but the CI is still failing. The PR you linked failed for the same reason.

@franciszekjob franciszekjob force-pushed the franciszekjob/fix-event-keys-ref branch from 6519fc8 to 555b525 Compare November 12, 2024 09:54
Copy link
Collaborator

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @franciszekjob)

@ArielElp ArielElp merged commit fe9acc4 into starkware-libs:v0.8.0 Nov 12, 2024
@franciszekjob franciszekjob deleted the franciszekjob/fix-event-keys-ref branch November 12, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants