feat: add name method to builtin enum #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2024
ArniStarkware
force-pushed
the
arni/mempool/builtin/name_trait
branch
from
215c917 to
499a729
Compare
|
This solves a todo in: starkware-libs/mempool#319 |
ArniStarkware
force-pushed
the
arni/mempool/builtin/name_trait
branch
from
499a729 to
17a0075
Compare
yair-starkware
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the method name to the Builtin enum.
This is connected to this request from the mempool repo: https://reviewable.io/reviews/starkware-libs/mempool/296#-O0O11mYC2gFg6AwJDAL
This change is