-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cairo_native): add native to stack trace test #2633
base: main
Are you sure you want to change the base?
Conversation
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1)
crates/blockifier/src/test_utils/contracts.rs
line 404 at r1 (raw file):
panic!("Not implemented for cairo native contracts") } }
This is waiting for LC to add the entry_point_by_type to the AotContractExacutor.
Code quote:
RunnableCompiledClass::V1Native(_) => {
#[cfg(test)]
{
EntryPointOffset(10000)
}
#[cfg(not(test))]
{
panic!("Not implemented for cairo native contracts")
}
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2633 +/- ##
===========================================
+ Coverage 40.10% 71.54% +31.44%
===========================================
Files 26 98 +72
Lines 1895 13634 +11739
Branches 1895 13634 +11739
===========================================
+ Hits 760 9755 +8995
- Misses 1100 3450 +2350
- Partials 35 429 +394 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/test_utils/contracts.rs
line 404 at r1 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
This is waiting for LC to add the entry_point_by_type to the AotContractExacutor.
Consider using the casm field
No description provided.