feat(native_blockifier): make cairo_native a feature of native blockifier

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(native_blockifier): make cairo_native a feature of native blockifier #2625 👈 (View in Graphite)
• fix(native_blockifier): activate testing feature only in dev dependencies #2624
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2024-12-10T11:50:18Z
• Started at 2024-12-10T12:15:44Z
• Started at 2024-12-10T14:22:04Z
• Started at 2024-12-10T16:07:58Z

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (12-10-fix_native_blockifier_activate_testing_feature_only_in_dev_dependencies@06da31a). Learn more about missing BASE report.

Additional details and impacted files

@@                                               Coverage Diff                                               @@
##             12-10-fix_native_blockifier_activate_testing_feature_only_in_dev_dependencies   #2625   +/-   ##
===============================================================================================================
  Coverage                                                                                 ?   9.73%           
===============================================================================================================
  Files                                                                                    ?     133           
  Lines                                                                                    ?   17499           
  Branches                                                                                 ?   17499           
===============================================================================================================
  Hits                                                                                     ?    1703           
  Misses                                                                                   ?   15455           
  Partials                                                                                 ?     341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[noaov1]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

scripts/build_native_blockifier.sh line 19 at r1 (raw file):

    pypy3.9 -m venv /tmp/venv
    source /tmp/venv/bin/activate
    cargo build --release -p native_blockifier --features "cairo_native" || clean

Do we also want to add it to the ci? I.e., building native blockifier with the cairo_native feature?

Code quote:

cargo build --release -p native_blockifier --features "cairo_native" 

---

crates/native_blockifier/Cargo.toml line 10 at r1 (raw file):

[features]
cairo_native = ["blockifier/cairo_native"]

Like :)

Code quote:

cairo_native = ["blockifier/cairo_native"]

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware)

---

scripts/build_native_blockifier.sh line 19 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Do we also want to add it to the ci? I.e., building native blockifier with the cairo_native feature?

this is the script the CI runs for the native blockifier build :)

[noaov1]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

---

scripts/build_native_blockifier.sh line 19 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this is the script the CI runs for the native blockifier build :)

Got it :) What about cargo test?