chore: use builtins iter to define os_order_iter #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on |
This was referenced Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## arni/declare/post_compilation/validation/trait_for_builtin_name #351 +/- ##
===================================================================================================
+ Coverage 82.58% 82.70% +0.11%
===================================================================================================
Files 33 33
Lines 1631 1642 +11
Branches 1631 1642 +11
===================================================================================================
+ Hits 1347 1358 +11
Misses 219 219
Partials 65 65 ☔ View full report in Codecov by Sentry. |
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
4733c8e to
2546a4b
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
63717fb to
4a3413b
Compare
This was referenced Jul 3, 2024
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
2546a4b to
6a332d4
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
2 times, most recently
from
1a35bd7 to
193d382
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
6a332d4 to
0f229c0
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
193d382 to
24a6ce6
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/compilation_file
branch
from
0f229c0 to
93e2b1b
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
24a6ce6 to
1c0bd82
Compare
ArniStarkware
changed the base branch from
arni/declare/compilation/compilation_file
to
arni/declare/post_compilation/validation/trait_for_builtin_name
ArniStarkware
force-pushed
the
arni/declare/post_compilation/validation/trait_for_builtin_name
branch
from
69054eb to
65d2d27
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
1c0bd82 to
33bb4e3
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/validation/trait_for_builtin_name
branch
from
65d2d27 to
cb35c83
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
33bb4e3 to
b47b3eb
Compare
ArniStarkware
force-pushed
the
arni/declare/post_compilation/validation/trait_for_builtin_name
branch
from
cb35c83 to
dba37cb
Compare
ArniStarkware
force-pushed
the
arni/declare/compilation/builtins/os_order_iter
branch
from
b47b3eb to
56c0a93
Compare
ArniStarkware
deleted the
arni/declare/compilation/builtins/os_order_iter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is