Updating the Diagnostics Pointer in wrong type for contract.

[Tomer-StarkWare]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @Tomer-StarkWare)

---

crates/cairo-lang-starknet/src/analyzer.rs line 84 at r1 (raw file):

                err.location(db)
                    .unwrap_or_else(|| contract.submodule_id.stable_ptr(db.upcast()).untyped()),
                format!("Failed to generate ABI: {err}"),

if you were supplied with location - you should still use it.

Code quote:

                err.location(db)
                    .unwrap_or_else(|| contract.submodule_id.stable_ptr(db.upcast()).untyped()),
                format!("Failed to generate ABI: {err}"),

---

crates/cairo-lang-starknet/src/plugin/plugin_test_data/contracts/interfaces line 1729 at r1 (raw file):

warning: Plugin diagnostic: Failed to generate ABI: Duplicate entry point: 'foo'. This is not currently supported.
 --> lib.cairo:56:5
    #[abi(embed_v0)]

this is definitely a degregation.

---

crates/cairo-lang-starknet/src/analyzer.rs line 88 at r1 (raw file):

                    break;
                }
            }

Suggestion:

            let mut contract_stable_ptr = if let Some(attr) = contract.module_id().find_attr(db, CONTRACT_ATTR) {
                attr.stable_ptr.untyped()
                } else {
                contract.submodule_id.stable_ptr(db.upcast()).untyped()
            };

[Tomer-StarkWare]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-starknet/src/analyzer.rs line 84 at r1 (raw file):

Previously, orizi wrote…

if you were supplied with location - you should still use it.

Done.

---

crates/cairo-lang-starknet/src/plugin/plugin_test_data/contracts/interfaces line 1729 at r1 (raw file):

Previously, orizi wrote…

this is definitely a degregation.

Done.

---

crates/cairo-lang-starknet/src/analyzer.rs line 88 at r1 (raw file):

                    break;
                }
            }

Done.

[orizi]

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @Tomer-StarkWare)

---

a discussion (no related file):
do you have any example that is still mapped to full contract?
(As this didn't change any diags)

---

crates/cairo-lang-starknet/src/analyzer.rs line 91 at r2 (raw file):

                err.location(db).unwrap_or(contract_stable_ptr),
                format!("Failed to generate ABI: {err}"),
            ));

Suggestion:

            let location = err.location(db).unwrap_or_else(
                || if let Ok(Some(attr)) = contract.module_id().find_attr(db, CONTRACT_ATTR) {
                    attr.stable_ptr.untyped()
                } else {
                    contract.submodule_id.stable_ptr(db.upcast()).untyped()
                });

            diagnostics.push(PluginDiagnostic::warning(
                location, format!("Failed to generate ABI: {err}")
            ));