Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge bitcoin#30122: bench: enable wallet creation benchmarks on all …
…platforms 7c8abf3 bench: bugfix, properly release wallet before erasing directory (furszy) Pull request description: Simple fix for bitcoin#29816. Since the wallet is appended to the global `WalletContext` during creation, merely calling `reset()` on the benchmark shared_pointer is insufficient to destruct the wallet. This no destruction of the wallet object results in keeping the db connection open, which was causes the `fs::remove_all()` failure on Windows. ACKs for top commit: maflcko: utACK 7c8abf3 kevkevinpal: utACK [7c8abf3](bitcoin@7c8abf3) hebasto: re-ACK 7c8abf3, I agree with changes since my recent [review](bitcoin#30122 (review)). Tree-SHA512: 279df65bea8f7aa02af0a2efed62dca9bf9b29cb748eb369c602d223e08a8a907dea7b1bffbd3dab91b1656c1d91b18a9a0534bc3f153bd751414b0e6230b3a4
- Loading branch information