changed summmary.py logic #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #121 +/- ##
===========================================
- Coverage 69.28% 27.94% -41.34%
===========================================
Files 22 13 -9
Lines 1478 1052 -426
===========================================
- Hits 1024 294 -730
- Misses 454 758 +304
|
iulusoy
approved these changes
Jun 26, 2023
… and mark them as long
|
Kudos, SonarCloud Quality Gate passed!
|
iulusoy
added a commit
that referenced
this pull request
Jun 27, 2023
* changed summmary.py logic * fixing test_summary * added macos for testing * fixed_display_test * fixed docs and exceptions * added dropout menu for summary * added new SummaryDetector to AnalysisExplorer * bug fixing * code improving * fixed test_display * fixed code smells * reduce tests for macos * added some tests and exceptions for summary init * changed CI, runs pytest independently * exclude test_analysisExplorer from macos in CI * moved some tests from test_init_summary to test_advanced_init_summary and mark them as long --------- Co-authored-by: Inga Ulusoy <[email protected]>
iulusoy
added a commit
that referenced
this pull request
Jun 28, 2023
* added exception for empty file list * added batching, randomness and multiple file extensions to find_files * added more default filetypes to find_files * changed summmary.py logic (#121) * changed summmary.py logic * fixing test_summary * added macos for testing * fixed_display_test * fixed docs and exceptions * added dropout menu for summary * added new SummaryDetector to AnalysisExplorer * bug fixing * code improving * fixed test_display * fixed code smells * reduce tests for macos * added some tests and exceptions for summary init * changed CI, runs pytest independently * exclude test_analysisExplorer from macos in CI * moved some tests from test_init_summary to test_advanced_init_summary and mark them as long --------- Co-authored-by: Inga Ulusoy <[email protected]> * fixing coverage report (#126) * fixed coverage report --------- Co-authored-by: Petr Andriushchenko <[email protected]> Co-authored-by: Inga Ulusoy <[email protected]>
|
The reason for the error was a bug in the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed summmary.py logic
solving #111