Test for "true" in wildcard property of authorization responses #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support for domains longer than 3 segments (ex. 1.www.mydomain.com). - No need for GODADDY_BASE. Domain will be automatically determined from full RR name. - Update to delete challenge records.
Replace all occurances of 2.47 with 2.49
…cludes the phrase "error"
…cludes the phrase "error"
fix deb binary link in README.md
Route53 bash
Update GoDaddy README
Hey there, I created a script to add get certificated with getssl using the [INWX Domrobot Python 3 Client](https://github.com/inwx/python-client)
Move to from dockerhub to github for pebble docker image
Create INWX API ACME Scripts
More test fixes
… for finalize order to return Valid
Wait for Finalize to finish processing as well as Order
|
Sorry - messed up and accidentally pushed my local merge to your branch without thinking! Change looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to help with non-compliant ACME implementations that pass
"wildcard": falsein authorization responses instead of leaving it off entirely as RFC8555 requires. See #843 for more details.