-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow spoon to show user defined png files in the report. #501
Open
sarmadali20
wants to merge
1
commit into
square:master
Choose a base branch
from
sarmadali20:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
spoon-client/src/test/java/com/squareup/spoon/SpoonRuleTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,90 @@ | ||
// Copyright 2012 Square, Inc. | ||
package com.squareup.spoon; | ||
|
||
import org.junit.After; | ||
import org.junit.Assert; | ||
import org.junit.Rule; | ||
import org.junit.Test; | ||
|
||
import java.io.File; | ||
import java.io.IOException; | ||
|
||
public final class SpoonRuleTest { | ||
@Rule public final SpoonRule spoon = new SpoonRule(); | ||
private static final String className = SpoonRuleTest.class.getName(); | ||
private static final String dirPath = className+"_random/SpoonRuleTest/"; | ||
private static final String pngName = dirPath+className+"_some.png"; | ||
private static final String xmlName = dirPath+className+"_some.xml"; | ||
@After | ||
public void tearDown() { | ||
safeDelete(new File(xmlName)); | ||
safeDelete(new File(dirPath)); | ||
safeDelete(new File(pngName)); | ||
} | ||
|
||
private void safeDelete(File file) { | ||
if(file.exists()) { | ||
file.delete(); | ||
} | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void invalidTagThrowsException() { | ||
spoon.screenshot(null, "!@#$%^&*()"); | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void screenshotWithFileThrowsExceptionWhenInvalidTag() { | ||
spoon.screenshot(null, "!@#$%^&*()",null); | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void screenshotWithFileThrowsExceptionWhenNullFile() { | ||
spoon.screenshot(null, "SOME_TAG",null); | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void screenshotWithFileThrowsExceptionWhenFileDoesNotExist() { | ||
spoon.screenshot(null, "SOME_TAG",new File(pngName)); | ||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void screenshotWithFileThrowsExceptionWhenFileExtentionNotPNG() throws IOException { | ||
|
||
File file = new File(xmlName); | ||
file.getParentFile().mkdirs(); | ||
file.createNewFile(); | ||
|
||
Assert.assertTrue(file.exists()); | ||
Assert.assertTrue(file.isFile()); | ||
spoon.screenshot(null, "SOME_TAG",file); | ||
|
||
} | ||
|
||
@Test(expected = IllegalArgumentException.class) | ||
public void screenshotWithFileThrowsExceptionWhenFileIsDir() throws IOException { | ||
|
||
File file = new File(dirPath); | ||
file.mkdirs(); | ||
|
||
Assert.assertTrue(file.exists()); | ||
Assert.assertTrue(file.isDirectory()); | ||
spoon.screenshot(null, "SOME_TAG",file); | ||
|
||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void screenshotWithFileThrowsExceptionWhenContextIsNull() throws IOException { | ||
|
||
File file = new File(pngName); | ||
file.getParentFile().mkdirs(); | ||
file.createNewFile(); | ||
|
||
Assert.assertTrue(file.exists()); | ||
Assert.assertTrue(file.isFile()); | ||
spoon.screenshot(null, "SOME_TAG",file); | ||
|
||
} | ||
|
||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just add this dependency on the test-app, not to all modules