Update Arg
for specs to use interface{}
instead of string
#192
+19
−26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
Arg
struct for spec arguments parses argument values in the spec asstring
types. This causes some pain for jobs that are running using values directly from the spec as they cannot be defined using more meaningful types (e.g.int
orbool
) and instead must expect values to be strings. Changing this to useinterface{}
allows values to be parsed by the yaml parser into primitives based on the content of the yaml file rather than forcing everything to be strings.