-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Allow an adjustable time difference for modification detection (Editor) #22192
base: 5.x
Are you sure you want to change the base?
Conversation
For CIFS (and perhaps other network file systems), where caching file attributes is used, expecting identical timestamps causes many false positives. This hacky patch allows for some deviation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @and1bm, thanks for your contribution! I left a small comment for you, otherwise looks good to me.
Hi @ccordoba12, I reverted the changes in the translatable string. |
Thanks! I think this is ready, so we just need your confirmation that it actually works in your systems to merge it. |
@and1bm, any news about this patch? Did it work for you? We're planning to release 5.5.6 soon and we'd like to include it in that release. |
@ccordoba12 sorry, we are still investigating, it seems not to fix all (?) problems. We have |
Ok, no problem. Let us know when you have more info. |
For CIFS (and perhaps other network file systems), where caching file attributes is used, expecting identical timestamps causes many false positives. This hacky patch allows for some deviation.
Description of Changes
Issue(s) Resolved
Fixes #21877 hopefully, we'll see next week when much more testing is planed in production.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: and1bm