Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Improve UI/UX of the Debugger pane #22163

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Jun 12, 2024

Description of Changes

  • Add new icons for the go to editor, interrupt and debug and list breakpoints actions.
  • Add new action and icon for postmortem debugging because it's easier to understand for users if we don't mix that functionality with interrupt and debug.
  • Don't use color scheme colors in the frames browser. That's because they are not necessarily compatible with the interface theme.
  • Allow the breakpoints table to be collapsed and remove minimum width for it.
  • Split main toolbar buttons in sections for clarity.

Visual changes

  • Main toolbar

    Before After
    imagen imagen
  • Frames browser

    Before After
    imagen imagen

Issue(s) Resolved

Fixes #22070.
Part of #21856.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

- The first section contains actions that control the debugger and the
second one has all other actions.
- Also, remove spinner because it's not necessary in the debugger.
- Don't use color scheme colors because not all of them work with our
the dark and light themes.
- Make frames formatting similar to the one displayed in the Find pane.
- Show frame scope to the right so that it's easier to read the frame
info. And also to give it more meaning.
- Remove passing fonts and colors to the constructor of several clases
because it's no longer necessary.
That's because they appeared too big next to the other toolbar icons in
the debugger.
- That allows us to represent it with a different icon which will make
more sense to users.
- Also, group actions that interact with the console in a new toolbar
section.
- Remove min width and allow to collapse it. That should fix an error
when snapping the main window on Linux.
- Also remove artificial min width for the stack widget that was only
introduced when the table was shown.
- Fix error in Python 3.10+ when setting the initial width for it.
@ccordoba12 ccordoba12 changed the title [WIP] PR: Improve UI/UX of the Debugger pane PR: Improve UI/UX of the Debugger pane Jun 12, 2024
@ccordoba12
Copy link
Member Author

I discussed these changes with @conradolandia (who also designed the new icons) and he agrees with them.

So, I'm going to merge this one.

@ccordoba12 ccordoba12 merged commit a9699ed into spyder-ide:master Jun 12, 2024
14 checks passed
@ccordoba12 ccordoba12 deleted the fix-debugger-ui branch June 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snapping Spyder 6 while Show breakpoints is active is broken
1 participant