-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to improve model creation speed #1149
Open
datejada
wants to merge
6
commits into
master
Choose a base branch
from
1148-add-option-to-disable-names-in-the-model
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results from the benchmark. Results with the name creation and bridges
Results disabling only the name creation
Results disabling the name creation and the bridges
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 87.33% 87.35% +0.01%
==========================================
Files 143 143
Lines 4130 4135 +5
==========================================
+ Hits 3607 3612 +5
Misses 523 523 ☔ View full report in Codecov by Sentry. |
datejada
changed the title
Add option to disable names
Add options to improve speed on model creation
Dec 3, 2024
datejada
changed the title
Add options to improve speed on model creation
Add options to improve model creation speed
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the performance tips from JuMP docs, this PR implements the following option in the
run_spineopt
function:use_model_names
(default =true
): whether or not bridges from JuMP to the solver should be added to the modeladd_bridges
(default =false
): whether or not to optimise the model (useful for running tests)Notes
The
use_model_names
default is equal totrue
, so the users can gain more speed when creating the model by setting this option tofalse
.The
add_bridges
option is set totrue
for the MGA algorithm, since it is necessary to run that feature.Fixes #1148
Checklist before merging