Merge pull request #302 from spacemeshos/retire-staticcheck

Run staticcheck only via golangci-lint

.github/workflows/ci.yml

@@ -28,8 +28,6 @@ jobs:
           make test-fmt
           make test-tidy
           make test-generate
-      - name: staticcheck
-        run: make staticcheck
 
   lint:
     runs-on: ubuntu-22.04

Makefile

@@ -1,10 +1,8 @@
 export CGO_ENABLED := 1
 include Makefile.Inc
 
-GOLANGCI_LINT_VERSION := v1.57.0
-STATICCHECK_VERSION := v0.4.7
-GOTESTSUM_VERSION := v1.11.0
-GOSCALE_VERSION := v1.1.13
+GOLANGCI_LINT_VERSION := v1.59.0
+GOTESTSUM_VERSION := v1.12.0
 MOCKGEN_VERSION := v0.4.0
 
 build: postcli
@@ -28,7 +26,6 @@ install: get-postrs-lib
 	go mod download
 	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s $(GOLANGCI_LINT_VERSION)
 	go install gotest.tools/gotestsum@$(GOTESTSUM_VERSION)
-	go install honnef.co/go/tools/cmd/staticcheck@$(STATICCHECK_VERSION)
 	go install go.uber.org/mock/mockgen@$(MOCKGEN_VERSION)
 .PHONY: install
 
@@ -72,10 +69,6 @@ cover: get-postrs-lib
 	@$(ULIMIT) CGO_LDFLAGS="$(CGO_TEST_LDFLAGS)" go test -coverprofile=cover.out -timeout 0 -p 1 -coverpkg=./... ./...
 .PHONY: cover
 
-staticcheck: get-postrs-lib
-	@$(ULIMIT) CGO_LDFLAGS="$(CGO_TEST_LDFLAGS)" staticcheck ./...
-.PHONY: staticcheck
-
 generate: get-postrs-lib
 	@$(ULIMIT) CGO_LDFLAGS="$(CGO_TEST_LDFLAGS)" go generate ./...
 .PHONY: generate

go.mod

@@ -1,6 +1,6 @@
 module github.com/spacemeshos/post
 
-go 1.22.2
+go 1.22.4
 
 require (
 	github.com/davecgh/go-spew v1.1.1

initialization/benchmark_test.go

@@ -13,6 +13,6 @@ func TestBenchmark(t *testing.T) {
 	for _, p := range providers {
 		hashes, err := Benchmark(p)
 		require.NoError(t, err)
-		require.Greater(t, hashes, 0)
+		require.Positive(t, hashes)
 	}
 }