[neighsync] Modification for ignoring neighbor entries #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. [neighsync] Ignore neighbor entries on non-router-interface 2. Don't ignore reserved IPv4 LL address - For BGP unnumber, reserved IPv4 LL (169.254.0.1) will be used as next hop. FRR configure it as permanent neighbor when BGP session is established. We ignore neighbor entry learned on non-router interface currently, this reserved IPv4 LL will not be synced if we don't configure use-link-local-only before this neighbor learnt event. 3. [neighsyncd] Ignore null MAC address neighbor while adding neighbor By executing the following commands would cause the netlink message bring a NULL MAC neighbor and cause the neighsyncd exception. The libnl api `nl_addr2str` would output the string `"none"` if the lladdr is `NULL`, and the string is an exception case for the class `MacAddress`. Therefore, this commit add to ignore this condition while the `rtnl_neigh_get_lladdr` can not retrieve the lladdr successfully ``` ip neigh replace 1.2.3.8 lladdr 00:33:55:66:55:66 dev Vlan10 nud noarp ip neigh replace 1.2.3.8 lladdr 00:33:55:66:55:66 dev Vlan10 nud none ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[neighsync] Ignore neighbor entries on non-router-interface
Don't ignore reserved IPv4 LL address
By executing the following commands would cause the netlink message bring a NULL MAC neighbor and cause the neighsyncd exception.
The libnl api
nl_addr2strwould output the string"none"if the lladdr isNULL, and the string is an exception case for the classMacAddress. Therefore, this commit add to ignore this condition while thertnl_neigh_get_lladdrcan not retrieve the lladdr successfully