Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented backlight dimming and added a few "registers" for configuring it (
REG_ID_BK3
andREG_ID_BK4
). I wasn't sure how much of the logic you wanted to expose in registers, so I decided to add some variables inbacklight.h
instead of bringing everything to the registers.I'm running the changes on my board and it seems to be working as intended: disabling the timeout disables dimming. And changing the timeout does result in a dimmer backlight. I'm pretty sure the alarm/timing could be improved but I didn't want to fire too many events and risk getting in the way of other tasks.