-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run spamfilters against NICK #330
base: main
Are you sure you want to change the base?
Conversation
This should also apply to the initial nick, otherwise one could still register with the bad nick. Alarm consumers would need to handle that situation, though. |
3c68c0c
to
abc23d5
Compare
extensions/filter.c
Outdated
} | ||
if (r & ACT_ALARM) { | ||
sendto_realops_snomask(SNO_GENERAL, L_ALL | L_NETWIDE, | ||
"FILTER:REGISTER: %s@%s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is my initial solution for how alarm consumers are going to handle this case: slightly different snote. bikeshed on the format please
struct Client *s = data->client; | ||
struct sockaddr *addr = (void *)&s->localClient->ip; | ||
|
||
if(find_conf_by_address( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't make people immune from this by them being an oper, obviously, and this is the only alternative that came to mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe we just treat it like a RESV. you have to connect first and then switch your nick
dca7d6e
to
7d5e73d
Compare
i plan to do a second PR after this that runs spamfilters against |
this isn't perfect because it'll format as
(note the
:
) so maybe I should beat upmatch_message
'ssnprintf
a bit