add gateway name field for auth blocks #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I seem to have sniped extban progval suggested |
Since the creation of this PR, a new module was introduced using the extban char `g`, creating an unforseen conflict. This commit changes that character to `w` to match the char used in inspircd
phy1729
reviewed
Jul 6, 2023
Comment on lines
+22
to
+24
| #include <capability.h> | ||
| #include <s_serv.h> | ||
| #include <s_newconf.h> |
There was a problem hiding this comment.
I don't think these are necessary (MAPI_CAP_CLIENT is defined in modules.h).
Comment on lines
+50
to
+53
| /* $w by itself will match all gateway users */ | ||
| if (data == NULL) | ||
| return EmptyString(client_p->gateway) ? EXTBAN_NOMATCH : EXTBAN_MATCH; | ||
| return match(data, client_p->gateway) ? EXTBAN_MATCH : EXTBAN_NOMATCH; |
There was a problem hiding this comment.
match seems to expect the second argument to be non NULL. I think this should be something like
if EmptyString(client_p->gateway)
return EXTBAN_NOMATCH;
/* $w by itself will match all gateway users */
if (data == NULL)
return EXTBAN_MATCH;
return match(data, client_p->gateway) ? EXTBAN_MATCH : EXTBAN_NOMATCH;| @@ -565,6 +568,21 @@ do_who(struct Client *source_p, struct Client *target_p, struct membership *mspt | |||
| q = "0"; | |||
| append_format(str, sizeof str, &pos, " %s", q); | |||
| } | |||
| if (fmt->fields & FIELD_GATEWAY) | |||
| { | |||
| /* use same the logic as account */ | |||
There was a problem hiding this comment.
Given the reasoning for account to do this 1, I don't think it makes sense to copy that logic for gateway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #213.