Removed deprecated function and component #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed deprecated ListView and componentWillReceiveProps with FlatList and componentDidUpdate respectively
amirulabu
pushed a commit
to vase/react-native-modal-dropdown
that referenced
this pull request
Jul 22, 2019
fungilation
suggested changes
Aug 1, 2019
| @@ -14,6 +14,8 @@ import { | |||
| View, | |||
| Text, | |||
| ListView, | |||
There was a problem hiding this comment.
Nice, using your fork since this repo seems like an orphan.
ListView import here should just be removed.
alexcrist
reviewed
Aug 28, 2019
| keyExtractor={(_, index) => index.toString()} | ||
| renderItem = {({item, index}) => this._renderRow(item, index)} | ||
| data={this.props.options} | ||
| renderSeparator={renderSeparator || this._renderSeparator} |
There was a problem hiding this comment.
In FlatList, renderSeparator was changed to ItemSeparatorComponent
|
Is someone planning to merge this PR? |
| @@ -88,9 +90,9 @@ export default class ModalDropdown extends Component { | |||
| }; | |||
| } | |||
|
|
|||
| componentWillReceiveProps(nextProps) { | |||
| componentDidUpate(prevProps, prevState){ | |||
There was a problem hiding this comment.
Small typo here, should be componentDidUpdate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed deprecated ListView and componentWillReceiveProps with FlatList and componentDidUpdate respectively