AOT package script #1836
Open
AOT package script #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciektr
force-pushed
the
spr/main/40843cae
branch
from
c572f47 to
b7e1b83
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
b7e1b83 to
b7878fe
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
b7878fe to
79b9773
Compare
maciektr
commented
Dec 10, 2024
scarb/src/ops/package.rs
Outdated
| copy_items_to_target_dir(includes, target_dir_path)?; | ||
| } | ||
|
|
||
| execute_script(script_definition, &[], ws, target_dir_path, None)?; |
There was a problem hiding this comment.
Why are we executing the script in target/package?
It seems to me it should be either executed in the root dir, or if we want avoid modifying any unnecessary files there, in target/package/<name>-<version>?
Originally posted in: #1789 (comment)
maciektr
force-pushed
the
spr/main/40843cae
branch
from
79b9773 to
db89364
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
db89364 to
4491d21
Compare
mkaput
approved these changes
Dec 12, 2024
DelevoXDG
reviewed
Dec 12, 2024
maciektr
force-pushed
the
spr/main/40843cae
branch
from
4491d21 to
9ac388f
Compare
maciektr
force-pushed
the
spr/main/d297a417
branch
2 times, most recently
from
01d1add to
8d172a9
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
9ac388f to
60a3324
Compare
DelevoXDG
approved these changes
Dec 13, 2024
maciektr
force-pushed
the
spr/main/d297a417
branch
from
8d172a9 to
2b52b2c
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
60a3324 to
3403ad2
Compare
maciektr
force-pushed
the
spr/main/d297a417
branch
from
2b52b2c to
c176d0a
Compare
maciektr
force-pushed
the
spr/main/40843cae
branch
from
3403ad2 to
e2d13dd
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
fixes #1770 --- **Stack**: - #1846 - #1836 - #1842 ⬅⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do not merge manually using the UI - doing so may have unexpected results.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1771
Stack: