draft: sketched out SO interface CI workflow. #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
core
|
I just sketched out how this could work, but this could be a project for Andy. |
tristpinsm
commented
Dec 2, 2024
| } | ||
| freeze = {} | ||
|
|
||
| with open('tests/ci/frozen_functions.py', 'r') as fh: #opens file "fname", in read mode 'r', to be used in code as "fh" |
There was a problem hiding this comment.
what is going to be stored in this file? Is it a pseudo-python representation of the objects/methods structure that define the interface?
tristpinsm
commented
Dec 2, 2024
| return True | ||
|
|
||
| if __name__ == "__main__": #if this is the main thing being run | ||
| for fname, spec in interface.items(): #loop over file names "fname" as keys and "spec" as values in dictionary called "interface" |
There was a problem hiding this comment.
currently interface is not defined
tristpinsm
commented
Dec 2, 2024
| for meth in spec[key]: #iterating over methods specified in spec[key] | ||
| assert meth in tree[key] | ||
| assert _compare_args(spec[key][meth], tree[key][meth]) | ||
| notfound = [] |
There was a problem hiding this comment.
these two lines don't need to be in the context manager
tristpinsm
commented
Dec 2, 2024
| notfound = [] | ||
| found = {} | ||
| dump = ast.dump(tree) | ||
| for node in ast.walk(tree): |
There was a problem hiding this comment.
the first layer in the tree is usually going to be made up of ClassDef objects (though not always), which in turn contain FunctionDef's. The original sketch had a check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft of github CI workflow to enforce compliance with the SO interface document here.
This is just a sketch and the code needs to be fleshed out, tested and documented.