Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to avoid cast when possible #113

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Update to avoid cast when possible #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Expressions/UnaryExpression.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,17 @@ public function evaluateImpl(row $row, AsyncMysqlConnection $conn): mixed {
invariant($op is nonnull, 'This case was not considered. The operator is null.');
switch ($op) {
case Operator::UNARY_MINUS:
return -1 * (float)$val;
// Keeping this cast around for backwards compat
if (!($val is num)) {
$val = (float)$val;
}
return -1 * $val;
case Operator::UNARY_PLUS:
return (float)$val;
// Keeping this cast around for backwards compat
if (!($val is num)) {
$val = (float)$val;
}
return $val;
case Operator::TILDE:
return ~(int)$val;
default:
Expand Down
Loading