Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sinon mod improvements #622

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

skirsdeda
Copy link
Contributor

  • support equals comparator
  • support resolves/rejects/throws/callsFake stub behavior methods universally (chained after on*Call/withArgs or standalone)
  • consolidate stub behavior transforms to enable more combinations
  • support global resets
  • fix ast-types dependency version to match jscodeshift requirement so that Typescript doesn't complain

Copy link
Owner

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skovhus skovhus enabled auto-merge (squash) November 5, 2024 12:28
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.75%. Comparing base (a94e2b5) to head (76c2ab3).
Report is 83 commits behind head on main.

Files with missing lines Patch % Lines
src/transformers/sinon.ts 98.46% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
+ Coverage   92.38%   92.75%   +0.37%     
==========================================
  Files          26       27       +1     
  Lines        1944     2099     +155     
  Branches      405      451      +46     
==========================================
+ Hits         1796     1947     +151     
- Misses        102      103       +1     
- Partials       46       49       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skovhus skovhus merged commit 33a62f9 into skovhus:main Nov 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants