fix: use compare with --cpu for Firefox failed. (#4324)

This catches if we got no longtask information.
sitespeedio · Nov 23, 2024 · 957fe52 · 957fe52
1 parent d3a27f4
commit 957fe52
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/lib/plugins/compare/helper.js b/lib/plugins/compare/helper.js
@@ -275,16 +275,18 @@ function getCPU(data) {
   };
 
   for (const run of data.cpu) {
-    const longTasks = run.longTasks;
-    cpuMetrics['tasks'].push(longTasks['tasks']);
-    cpuMetrics['totalDuration'].push(longTasks['totalDuration']);
-    cpuMetrics['lastLongTask'].push(longTasks['lastLongTask']);
-    cpuMetrics['beforeFirstContentfulPaint'].push(
-      longTasks['beforeFirstContentfulPaint'].totalDuration
-    );
-    cpuMetrics['beforeLargestContentfulPaint'].push(
-      longTasks['beforeLargestContentfulPaint'].totalDuration
-    );
+    if (run.longTasks) {
+      const longTasks = run.longTasks;
+      cpuMetrics['tasks'].push(longTasks['tasks']);
+      cpuMetrics['totalDuration'].push(longTasks['totalDuration']);
+      cpuMetrics['lastLongTask'].push(longTasks['lastLongTask']);
+      cpuMetrics['beforeFirstContentfulPaint'].push(
+        longTasks['beforeFirstContentfulPaint'].totalDuration
+      );
+      cpuMetrics['beforeLargestContentfulPaint'].push(
+        longTasks['beforeLargestContentfulPaint'].totalDuration
+      );
+    }
   }
 
   const isEmpty = Object.values(cpuMetrics).every(arr => arr.length === 0);