-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next version #540
Open
simulot
wants to merge
264
commits into
main
Choose a base branch
from
next
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Next version #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `Browse` and `passTwo` methods in `LocalAssetBrowser` to return `AssetGroup` instead of `LocalAssetFile`. - Implemented logic to handle different types of asset groups (e.g., motion photos, single images, videos). - Added album management for asset groups. - Introduced `AssetGroup` struct in `group.go` to represent linked assets. - Updated tests to validate and handle `AssetGroup` instead of individual assets. - Removed redundant album management code from `assetFromFile` method.
- Updated `ReadMetadata`, `metadataFromExiftool`, and `metadataFromDirectRead` functions to return `*metadata.Metadata` and `error` instead of setting `la.Metadata` directly. - Adjusted logic to handle the returned metadata and error appropriately.
… is DateMethodNameThenExif
- Add functionality to list the flags and arguments used in the command to provide more context in the logs.
…ind flags to environment variables
…ind flags to environment variables
…ind flags to environment variables Refactor NewRecorder() in fileevents.go to remove debug parameter Refactor AddCommands() in commands.go to use context and application parameters Refactor .goreleaser.yaml to update ldflags for version and commit Refactor CommandTool() in tool.nogo to remove unused imports and update error message Refactor readFolder.go to update function signature and parameter names Refactor version.go to initialize version and commit at runtime Refactor banner.go to update banner with version information Refactor flagsCommon.go to remove unused flags and function Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG.json to update creationTime and photoTakenTime Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238_1.JPG.json to update creationTime and photoTakenTime Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG(1).json to update creationTime and photoTakenTime Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG to add new file Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238_1.JPG to add new file Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238(1).JPG to add new file Refactor upload/TEST_DATA/Takeout2/Google Photos/Sans titre(9)/métadonnées.json to add new file Refactor upload/TEST_DATA/Takeout1/Google Photos/Album test 6-10-23/métadonnées.json to add new file Refactor cmdVersion/version.go to remove unused file Refactor version/version.go to update version and commit initialization Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG.json to update geoData Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238_1.JPG.json to update geoData Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG(1).json to update geoData Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238.JPG to update title and creationTime Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238_1.JPG to update title and creationTime Refactor upload/TEST_DATA/Takeout3/Photos from 2023/DSC_0238(1).JPG to update title and creationTime Refactor upload/TEST_DATA/Takeout2/Google Photos/Sans titre(9)/métadonnées.json to update title and creationTime Refactor upload/TEST_DATA/Takeout1/Google Photos/Album test 6-10-23/métadonnées.json to update title and creationTime
…urces - The `upload` command has been refactored to use separate sub-commands for different sources of photos. - The `upload` command now has a `from-folder` sub-command to upload photos from a folder. - The `upload` command also has a `from-google-photos` sub-command to upload photos from a Google Photos takeout.
…les and adjusting date handling
…ture date is zero
…and discard messages
… extraction and updating expected counts
…update test case expectations
…d remove ExifTool dependency
Simulot/issue543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete rewrite of Immich-go