Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for picasa ini files for metadata #430

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lancerushing
Copy link

No description provided.

@@ -92,6 +99,15 @@ func (la *LocalAssetBrowser) passOneFsWalk(ctx context.Context, fsys fs.FS) erro
if dir == "" {
dir = "."
}

// TODO Add check for app.Picasa first.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to figure this out.

@lancerushing
Copy link
Author

There are a few things I want to add, but I wanted to get your input before I add too much polish.

  1. Which pattern to use to inject the app.Picasa flag into localasset? Are you good with me add picasa bool to the signature of ExploreLocalFolder(ctx context.Context, fsyss []fs.FS) New: ExploreLocalFolder(ctx context.Context, fsyss []fs.FS, picasa bool)

  2. I'll add more tests (especially upload_test.go)

  3. I used github.com/spf13/afero to help with os.file abstraction. I noticed that we have github.com/psanford/memfs. I think afero is nicer, more active, etc. But it does have many more dependencies... 🤔

Do you want me to:
a) leave both in (doesn't mater)
b) convert the memfs code to afero
c) convert the afero code to memfs

Let me know, and I will get the code done.
-Lance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants