Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Id attribute to the prefix string. #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gabrieljenik
Copy link
Contributor

The prefix string is built so identifies uniquely each saved element
This is usefull when having more than 1 element with the same name. (Ex. checkboxes with the same name)

The prefix string is built so identifies uniquely each saved element
This is usefull when having more than 1 element with the same name. (Ex. checkboxes with the same name)
@simsalabim
Copy link
Owner

Thanks for the contribution! At a quick glance - it also introduces a bunch of unused variables, but I'll try take a closer look at it later.

@gabrieljenik
Copy link
Contributor Author

About unused variables: They are inside a method, for a more readable code. :)

@simsalabim
Copy link
Owner

By method extract you left a bunch of variables unused in their original places.
For example: https://github.com/gabrieljenik/sisyphus/blob/patch-2/sisyphus.js#L233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants