Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of tinymce editor #111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jerrywham
Copy link

I follow your own way of work and adapt them for tinymce object.
I hope you'll take my request in account.

@simsalabim
Copy link
Owner

Thanks a lot for the contribution! I am looking at the changes in whitespace-ignoring mode. Please follow the style guides and use tabs instead of spaces.

Also, can you please remove minified version from the pull request? Thanks!

}
},

isTinyMCEPresent: function() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems redundant because it returns value of this.isTinyMCEExists().

@bartclaeys
Copy link

Which Tinymce version does this commit support?

@Ma3oBblu
Copy link

Ma3oBblu commented Mar 1, 2017

thanks for commit. can you merge it in master?

@simsalabim
Copy link
Owner

@Ma3oBblu I like the intent of the PR but I can't merge it in this state: it has unresolved feedback and wasn't rebased off of master so GitHub doesn't allow to merge it automatically. I'm not actively developing the project right now, but if you want to pick where the author left off and complete this functionality, I'd highly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants