Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[puppetsync] Don't ignore Puppet 8 failures #149

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

silug
Copy link
Contributor

@silug silug commented Jun 12, 2024

Puppet 8 failures should not be ignored.

Also

  • Use the correct Ruby version for Puppet 8 tests
  • Manage spec/spec_helper.rb in Puppet modules

@silug silug force-pushed the 20240612-puppet8-tests branch 5 times, most recently from f33458e to eed704f Compare June 18, 2024 15:40
@silug silug force-pushed the 20240612-puppet8-tests branch 2 times, most recently from ce06a30 to 6360127 Compare July 8, 2024 18:59
Puppet 8 failures should not be ignored.

Also
* Use the correct Ruby version for Puppet 8 tests
* Manage spec/spec_helper.rb in Puppet modules
Copy link
Contributor

@rgardner4012 rgardner4012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👻

@rgardner4012 rgardner4012 merged commit 5b82e1b into simp:master Jul 11, 2024
8 checks passed
@silug silug deleted the 20240612-puppet8-tests branch September 13, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants