-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix USX corpus issues #138
Conversation
Is this issue in Machine as well? |
I am assuming that this is how tables are normally defined in USX. Is there any range of how they are defined? Are there edge cases that are not being caught? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Machine.NET probably has the same issues.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)
tests/corpora/test_usx_memory_text.py
line 35 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
I am assuming that this is how tables are normally defined in USX. Is there any range of how they are defined? Are there edge cases that are not being caught?
This is the only way that they are defined in USX. There could be edge cases, but I'm not aware of any.
New issue opened: sillsdev/machine#268 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
This change is