Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix USX corpus issues #138

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix USX corpus issues #138

merged 2 commits into from
Nov 6, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Nov 5, 2024

  • Fix incorrect handling of descriptive titles
  • Add support for tables

This change is Reviewable

@johnml1135
Copy link
Collaborator

Is this issue in Machine as well?

@johnml1135
Copy link
Collaborator

tests/corpora/test_usx_memory_text.py line 35 at r1 (raw file):

    <row style="tr">
      <cell style="tc1" align="start"><verse number="1" style="v" />Chapter</cell>
      <cell style="tcr2" align="end">1</cell>

I am assuming that this is how tables are normally defined in USX. Is there any range of how they are defined? Are there edge cases that are not being caught?

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

Copy link
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Machine.NET probably has the same issues.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @johnml1135)


tests/corpora/test_usx_memory_text.py line 35 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

I am assuming that this is how tables are normally defined in USX. Is there any range of how they are defined? Are there edge cases that are not being caught?

This is the only way that they are defined in USX. There could be edge cases, but I'm not aware of any.

@johnml1135
Copy link
Collaborator

New issue opened: sillsdev/machine#268

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 1d1dc25 into main Nov 6, 2024
14 checks passed
@johnml1135 johnml1135 deleted the usx-descriptive-title branch November 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants