migrate from NHunspell to WeCantSpell.Hunspell #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with modifying the word list at runtime.
LCM Tests 16 files ±0 16 suites ±0 3m 3s ⏱️ +11s For more details on these failures, see this check. Results for commit a0f0789. ± Comparison against base commit 93d7e90. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now LCM is using NHunspell, which hasn't been updated in 9 years and only supports dotnet framework (it does work on windows through compatibility, but not any other platform).
It looks like the suggested alternative is WeCantSpell.Hunspell.
One issue with WeCantSpell is that it makes the wordlist read only once it's been parsed. There's a discussion about that here, from what I can tell that's the biggest hurdle blocking us from adopting the library. I gave it a try, but I don't understand some of the Hunspell details enough to figure out what's going on in our old version.
Waiting for #306 to be merged in so the tests run.
This change is