Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data-testid, aria-label to general buttons, dialogs #3299

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 7, 2024

In preparation for using @testing-library/react more broadly (see #3180).


This change is Reviewable

@imnasnainaec imnasnainaec added frontend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Aug 7, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.64%. Comparing base (bfc9230) to head (b440dd6).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/components/Dialogs/DeleteEditTextDialog.tsx 0.00% 1 Missing ⚠️
src/components/Dialogs/EditTextDialog.tsx 0.00% 1 Missing ⚠️
src/components/Dialogs/SubmitTextDialog.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3299      +/-   ##
==========================================
- Coverage   74.67%   74.64%   -0.04%     
==========================================
  Files         280      280              
  Lines       10734    10734              
  Branches     1296     1296              
==========================================
- Hits         8016     8012       -4     
- Misses       2353     2356       +3     
- Partials      365      366       +1     
Flag Coverage Δ
backend 83.81% <ø> (-0.09%) ⬇️
frontend 66.64% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft August 21, 2024 16:13
@imnasnainaec imnasnainaec changed the title Add data-testid to general buttons and dialogs Add data-testid, aria-label to general buttons, dialogs Aug 21, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review August 21, 2024 16:43
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 18 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit ff4350f into master Aug 27, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the data-testid branch August 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants